Add additional parameters to ContentsUploadModal to be reusable in different scenarios #5881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto canceled.
|
✅ Deploy Preview for plone-components canceled.
|
erral
changed the title
ichim-david
reviewed
Mar 16, 2024
Comment on lines
225
to
239
| if (multiple) { | ||
| dropzoneOptions['multiple'] = multiple; | ||
| } | ||
| if (minSize) { | ||
| dropzoneOptions['minSize'] = minSize; | ||
| } | ||
| if (maxSize) { | ||
| dropzoneOptions['maxSize'] = maxSize; | ||
| } | ||
| if (accept) { | ||
| dropzoneOptions['accept'] = accept; | ||
| } | ||
| if (disabled) { | ||
| dropzoneOptions['disabled'] = disabled; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (multiple) { | |
| dropzoneOptions['multiple'] = multiple; | |
| } | |
| if (minSize) { | |
| dropzoneOptions['minSize'] = minSize; | |
| } | |
| if (maxSize) { | |
| dropzoneOptions['maxSize'] = maxSize; | |
| } | |
| if (accept) { | |
| dropzoneOptions['accept'] = accept; | |
| } | |
| if (disabled) { | |
| dropzoneOptions['disabled'] = disabled; | |
| } | |
| const dropzoneOptions = { | |
| multiple, | |
| minSize, | |
| maxSize, | |
| accept, | |
| disabled, | |
| }; |
@erral you could simplify this code as such and you wouldn't need to have all of these if statements.
I assume that the drag and drop library would know to handle even the options that have null values
There was a problem hiding this comment.
Thanks @ichim-david surely it will. I am still a react novice for such structures and still go for if-like thingies. 😅 I will check if the library handles the null values correctly.
There was a problem hiding this comment.
I have checked this and indeed the plugin handless the null values correctly, so I have updated the PR. Thanks again for the review.
ichim-david
approved these changes
Mar 17, 2024
stevepiercy
reviewed
Mar 29, 2024
Co-authored-by: Steve Piercy <[email protected]>
stevepiercy
approved these changes
Mar 29, 2024
sneridagh
added a commit
that referenced
this pull request
Apr 16, 2024
* main: (28 commits) Bump vite from 5.1.5 to 5.1.7 (#5946) Fix pt_BR translation of invalid email message (#5953) Fix markup shortcuts for bold, italic and strikethough fix (#5606) Release 18.0.0-alpha.27 Release @plone/types 1.0.0-alpha.10 Improve color widget picker and types (#5948) Enhanced navigation reducer in Volto (#5817) Release 18.0.0-alpha.26 Rename news item Release @plone/slate 18.0.0-alpha.11 Release @plone/registry 1.5.5 Release @plone/types 1.0.0-alpha.9 docs: Cleanup obsolete EEA projects and update info about EEA main website (#5943) Bump vite from 5.1.4 to 5.1.5 (#5942) Add a new label `needs: triage` to new bug reports (#5940) Fix redirect of `https://sustainability.eionet.europa.eu` to `https:/… (#5941) Does not show borders in addon block inputs (#5898) Fix edge case in search options mangling when the options are false-ish (#5869) Add additional parameters to ContentsUploadModal to be reusable in different scenarios (#5881) fix(slate): fix insert/remove element edgecase bug in slate (#5926) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent project I have found
ContentsUploadModalvery useful, and I have copied it over to provide the end-user with file upload capabilities.But as I wanted to restrict its use (max file size, only allow images, ...) and I have seen that react-dropzone's
<Dropzone />allows extra parameters, I have added the option to ContentsUploadModal to pass additional parameters to Dropzone.This way, one can simply reuse the modal component, which is great.